Remove RawArrayData #110902
Open
Remove RawArrayData #110902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalPetryka
requested review from
steveisok,
vitek-karas and
MichalStrehovsky
as code owners
dotnet-issue-labeler
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
3 tasks
jkotas
reviewed
Dec 23, 2024
| // This field should be the first field in Array as the runtime/compilers depend on it | ||
| private int _numComponents; | ||
| #pragma warning restore | ||
| internal uint RawLength; // Array._numComponents padded to IntPtr |
There was a problem hiding this comment.
This should follow dotnet/runtime naming conventions for fields.
I do not see a problem with this performance wise. However, I expect that there is going to be a long tail of places that are not prepared to handle fields on array type. Some of them may be outside dotnet/runtime. There may be more straightforward (less breaking) ways to get rid of RawArrayData. For example, call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes RawArrayData and makes Array reflect the actual runtime layout instead.
Makes code a bit safer by removing
Unsafe.Asusages with invalid types.cc @EgorBo @tannergooding I ended up doing this after the discussion on Discord
cc @jkotas There was one CoreCLR assert here due to array MT creation not setting the field count, I made it set it here in debug to avoid that and any perf impact in release, is that okay to do?