Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat INDEX_ADDRs as non-null #69209

Merged
merged 2 commits into from
May 12, 2022
Merged

Treat INDEX_ADDRs as non-null #69209

merged 2 commits into from
May 12, 2022

Conversation

SingleAccretion
Copy link
Contributor

A small improvement in preparation of replacing INDEX nodes with INDEX_ADDR nodes.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 11, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 11, 2022
@ghost
Copy link

ghost commented May 11, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

A small improvement in preparation of replacing INDEX nodes with INDEX_ADDR nodes.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@SingleAccretion SingleAccretion changed the title Treat INDEX_ADDRs as non-null Treat INDEX_ADDRs as non-null May 11, 2022
@TIHan
Copy link
Contributor

TIHan commented May 12, 2022

preparation of replacing INDEX nodes with INDEX_ADDR nodes.

Is there an issue or another PR that expands on this?

@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented May 12, 2022 •
edited
Loading

Is there an issue or another PR that expands on this?

It is part of #11057. The commit message for the INDEX change summarizes it well I think:

Delete GT_INDEX

Instead:
 1) For "ldelem", import "IND/OBJ(INDEX_ADDR)".
 2) For "ldelema", import "INDEX_ADDR".

This deletes two usages of "ADDR":
 1) "OBJ(ADDR(INDEX))" from "ldelem<struct>".
 2) "ADDR(INDEX)" from "ldelema".

@SingleAccretion SingleAccretion marked this pull request as ready for review May 12, 2022 11:01
@SingleAccretion
Copy link
Contributor Author

Libraries Test Run checked coreclr OSX x64 Debug had the same test fail here; will assume it is not related.

Diffs.

@dotnet/jit-contrib

@BruceForstall BruceForstall merged commit ff9040a into dotnet:main May 12, 2022
@SingleAccretion SingleAccretion deleted the Arr-Addr-Index-NotNull branch May 12, 2022 19:48
@ghost ghost locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SingleAccretion @TIHan @BruceForstall