Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix InstanceDataCollectionCollection_CopyTo by retrying on 0 values #70119

Merged
merged 5 commits into from
Jun 2, 2022
Merged

fix InstanceDataCollectionCollection_CopyTo by retrying on 0 values #70119

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd3bbc9
fix InstanceDataCollectionCollection_CopyTo by retrying on 0 values
smasher164 Jun 1, 2022
43ba3ad
add ZeroDataException
smasher164 Jun 2, 2022
5764034
Revert "add ZeroDataException"
smasher164 Jun 2, 2022
89d85ab
throw xUnitException instead of making a custom one
smasher164 Jun 2, 2022
1df74ad
no need for if statement
smasher164 Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/libraries/System.Diagnostics.PerformanceCounter/tests/InstanceDataTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,16 @@ public static void InstanceDataCollectionCollection_CopyTo()

public static InstanceDataCollectionCollection GetInstanceDataCollectionCollection()
{
PerformanceCounterCategory pcc = Helpers.RetryOnAllPlatforms(() => new PerformanceCounterCategory("Processor"));
return Helpers.RetryOnAllPlatforms(() => pcc.ReadCategory());
PerformanceCounterCategory pcc = Helpers.RetryOnAllPlatforms(() => new PerformanceCounterCategory("Processor"));
return Helpers.RetryOnAllPlatforms(() =>
{
var idcc = pcc.ReadCategory();
if (idcc.Values.Count == 0)
{
throw new Exception();
}
return idcc;
});
}

public static InstanceDataCollection GetInstanceDataCollection()
Expand Down