[release/6.0] Use BOOL (vs. bool) in event pipe qcall signatures

[VSadov]

Backport of #74389 to release/6.0
Fixes: #81181

There is an API signature mismatch (C++ bool vs. C BOOL , 1 vs. 4 byte) when exporting native event pipe helpers, which causes occasional nondeterministic crashes in apps.

Customer Impact

Applications that use EventSource and published as SingleFile will randomly crash with AccessViolationException.
(the crash may happen in non-singlefile configuration as well, in theory, but was not observed)

Testing

Manual validation of a repro scenario. (app crashes after a minute or so, no crash after the fix)
The same fix was ported to 7.0 a while ago and there is a lot of evidence that the crash no longer happens.

Risk

Low. We are fixing obviously incorrect signatures.

[VSadov]

cc: @AaronRobinsonMSFT @agocke

[AaronRobinsonMSFT]

Assuming the DllImport definitions weren't changed in .NET 6, this looks good.

[VSadov]

Assuming the DllImport definitions weren't changed in .NET 6

The definitions changed in 7.0 slightly and we got more entries like this, so this is not an automated backport, but the fix is essentially the same: bool -> BOOL replacing in signatures in eventpipeinternal.cpp, eventpipeinternal.h

[VSadov]

The DllImport in 6.0 does not specify bool marshaling explicitly, which means it defaults to 4-byte BOOL.

        //
        // These PInvokes are used as part of the EventPipeEventDispatcher.
        //
        [DllImport(RuntimeHelpers.QCall, CharSet = CharSet.Unicode)]
        internal static extern unsafe bool GetSessionInfo(ulong sessionID, EventPipeSessionInfo* pSessionInfo);

        [DllImport(RuntimeHelpers.QCall, CharSet = CharSet.Unicode)]
        internal static extern unsafe bool GetNextEvent(ulong sessionID, EventPipeEventInstanceData* pInstance);

[jeffschwMSFT]

approved. we will take for consideration in 6.0.x

[carlossanlop]

Closing and reopening to rebase the PR on top of the latest infra fixes merged to the branch. The CI had too many failures and the logs are unfortunately gone already.

[carlossanlop]

Approved by Tactics for 6.0.15.
Signed off by area owner.
No OOB changes needed for this PR.
CI failures are known and unrelated: #81807, #80476, #81851, #81391.
Ready to merge.