[release/7.0] [NativeAOT] correctly initalize CONTEXT before failing fast #81837
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Vladimir Sadov <[email protected]>
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #81010 to release/7.0 /cc @jkotas @AustinWise Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@janvorli @jkotas Don't forget to add the CI results are known and unrelated: #81544 #81391. We merged a fix for them a few hours after this PR was created: #81712. |
|
I have sent email yesterday and it has been approved already. |
carlossanlop
added
Servicing-approved
|
@jkotas Found it. Weird, Outlook wasn't finding the email by title, but I was able to find it by sender. Approved by Tactics for 7.0.4. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #81010 to release/7.0
/cc @jkotas @AustinWise
Customer Impact
Crash dumps of native AOT processes are undebuggable. The debugger does not show the stacktrace of the crash.
The problem is caused by uninitialized fields of CONTEXT structure, and thus it is non-deterministic. It seems to be more likely to happen on Windows 11 22H2.
Testing
Verified that the crash dump is diagnosable using deterministic repro (thank you @AustinWise for creating one!)
Risk
Low. The fix affects code path is only executed right before the process is about to crash.