Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update alpine test images #81841

Merged
merged 5 commits into from
Feb 16, 2023
Merged

update alpine test images #81841

merged 5 commits into from
Feb 16, 2023

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Feb 8, 2023

Contributes to #81901. (brings microsoft/msquic#3417)
3.17 has OpenSSL 3.

@wfurt wfurt self-assigned this Feb 8, 2023
@ghost
Copy link

ghost commented Feb 8, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

PoC

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Quic

Milestone: -

@wfurt
Copy link
Member Author

wfurt commented Feb 9, 2023

"production" tags are not available yet but runs with new msquic look good to me:

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-81841-merge-bd6ceb72150342b389/System.Net.Quic.Functional.Tests/1/console.66df93c4.log

Console log: 'System.Net.Quic.Functional.Tests' from job bd6ceb72-1503-42b3-890c-79d02443e771 (ubuntu.1804.amd64.open.rt) using docker image mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.15-helix-amd64-20230208010517-6d7b22b on a008BZ9


===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 107 of 113 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on, max threads = 2)
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.SupportedWindowsPlatforms_IsSupportedIsTrue [SKIP]
      Condition(s) not met: "IsWindows"
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 327, Errors: 0, Failed: 0, Skipped: 2, Time: 68.626s
/root/helix/work/workitem/e
----- end Wed Feb 8 23:36:28 UTC 2023 ----- exit code 0 ----------------------------------------------------------

and Alpine 3.17 with OpenSSL 3 and system crypto

Console log: 'System.Net.Quic.Functional.Tests' from job 6a8738e2-7105-47e3-a84c-bc54c4fded4b (ubuntu.1804.amd64.open.rt) using docker image mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.17-helix-amd64-20230208010446-6d7b22b on a008C1Y

==========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 107 of 113 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on, max threads = 2)
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.SupportedWindowsPlatforms_IsSupportedIsTrue [SKIP]
      Condition(s) not met: "IsWindows"
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 327, Errors: 0, Failed: 0, Skipped: 2, Time: 118.050s

cc: @dotnet/ncl @nibanks

@wfurt
Copy link
Member Author

wfurt commented Feb 10, 2023

https://helix.dot.net/api/2019-06-17/jobs/c1c454ca-990d-429c-845f-3665f97df231/workitems/System.ComponentModel.Annotations.Tests/console

 Discovering: System.ComponentModel.Annotations.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.ComponentModel.Annotations.Tests (found 389 of 395 test cases)
  Starting:    System.ComponentModel.Annotations.Tests (parallel test collections = on, max threads = 2)
    System.ComponentModel.DataAnnotations.Tests.RangeAttributeTests.CommaDecimalExtremaAndNonStringValues(type: typeof(decimal), min: "1,0", max: "3,0", value: 1.0) [FAIL]
      System.ArgumentException : 1,0 is not a valid value for Decimal. (Parameter 'value')
      ---- System.FormatException : The input string '1,0' was not in a correct format.
      Stack Trace:
        /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/BaseNumberConverter.cs(80,0): at System.ComponentModel.BaseNumberConverter.ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, Object value)
        /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeConverter.cs(82,0): at System.ComponentModel.TypeConverter.ConvertFromString(String text)
        /_/src/libraries/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/RangeAttribute.cs(209,0): at System.ComponentModel.DataAnnotations.RangeAttribute.SetupConversion()
        /_/src/libraries/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/RangeAttribute.cs(116,0): at System.ComponentModel.DataAnnotations.RangeAttribute.IsValid(Object value)
        /_/src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/RangeAttributeTests.cs(436,0): at System.ComponentModel.DataAnnotations.Tests.RangeAttributeTests.CommaDecimalExtremaAndNonStringValues(Type type, String min, String max, Object value)
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs(59,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
        ----- Inner Stack Trace -----
        /_/src/libraries/System.Private.CoreLib/src/System/Number.Parsing.cs(2720,0): at System.Number.ThrowOverflowOrFormatException(ParsingStatus status, ReadOnlySpan`1 value, TypeCode type)
        /_/src/libraries/System.Private.CoreLib/src/System/Number.Parsing.cs(2262,0): at System.Number.ParseDecimal(ReadOnlySpan`1 value, NumberStyles styles, NumberFormatInfo info)
        /_/src/libraries/System.Private.CoreLib/src/System/Decimal.cs(536,0): at System.Decimal.Parse(String s, NumberStyles style, IFormatProvider provider)
        /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/DecimalConverter.cs(69,0): at System.ComponentModel.DecimalConverter.FromString(String value, NumberFormatInfo formatInfo)
        /_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/BaseNumberConverter.cs(75,0): at System.ComponentModel.BaseNumberConverter.ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, Object value)
    System.ComponentModel.DataAnnotations.Tests.RangeAttributeTests.CommaDecimalExtremaAndNonStringValues(type: typeof(decimal), min: "1,0", max: "3,0", value: 3.0) [FAIL]
      System.ArgumentException : 1,0 is not a valid value for Decimal. (Parameter 'value')

do you have any idea why this may be failing @tarekgh? I'm trying to add new image and and this seems to be close to localization...? If you do not know, who else should I ask?

@tarekgh
Copy link
Member

tarekgh commented Feb 10, 2023

do you have any idea why this may be failing @tarekgh Tarek Mahmoud Sayed FTE?

This is clearly the culture used to parse the number is not the same used formatting the number. '1,0' is using , as a decimal point which does not match the decimal point used during parsing. Any idea how we get this number '1,0' in the first place? I mean who generated this string which we are trying to parse?

@tarekgh
Copy link
Member

tarekgh commented Feb 10, 2023

Looking more at the test, it looks like the test expect to run with the fr-FR culture. First, we need to check if the Alpine image not having the Invariant globalization mode on by default. And if it is not on, we need to check if the fr-FR culture in this image has the right data (The decimal point is defined as ,). Just print the output of

Console.WriteLine($"{CultureInfo.GetCultureInfo("fr-FR").NumberFormat.NumberDecimalSeparator}");

@wfurt is this something you can help checking? or share the image and I can try it.

@wfurt wfurt requested a review from a team February 12, 2023 02:43
@wfurt wfurt added this to the 8.0.0 milestone Feb 12, 2023
@wfurt wfurt marked this pull request as ready for review February 12, 2023 02:43
@wfurt
Copy link
Member Author

wfurt commented Feb 12, 2023

Localization issues resolved. Thanks @tarekgh. it is ready for review.

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@wfurt wfurt merged commit 82c8918 into dotnet:main Feb 16, 2023
@wfurt wfurt deleted the alpine317 branch February 16, 2023 18:12
@ManickaP
Copy link
Member

Looks like this is not complete, there are now tons of failing tests on Alpine 3.14, see the edit in #81901

ManickaP added a commit that referenced this pull request Feb 17, 2023
ManickaP added a commit that referenced this pull request Feb 18, 2023
* Revert "update alpine test images (#81841)"

This reverts commit 82c8918.

* Update eng/pipelines/libraries/helix-queues-setup.yml

* Update eng/pipelines/libraries/helix-queues-setup.yml
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants