Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Pick some low-hanging fruit in LSRA throughput #81916

Merged
merged 10 commits into from
Feb 10, 2023
Merged

JIT: Pick some low-hanging fruit in LSRA throughput #81916

merged 10 commits into from
Feb 10, 2023

Conversation

jakobbotsch
Copy link
Member

Probably easiest to review this commit-by-commit.

  • Remove LinearScan::RegisterSelection::score, replace it by a couple of bools
  • Remove various fields from LinearScan::RegisterSelection::reset, either by inlining their definitions at their uses, or because they are unconditionally assigned before their uses anyway
  • Reorder all fields that are zero initialized to happen in sequence

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 9, 2023
@ghost ghost assigned jakobbotsch Feb 9, 2023
@ghost
Copy link

ghost commented Feb 9, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Probably easiest to review this commit-by-commit.

  • Remove LinearScan::RegisterSelection::score, replace it by a couple of bools
  • Remove various fields from LinearScan::RegisterSelection::reset, either by inlining their definitions at their uses, or because they are unconditionally assigned before their uses anyway
  • Reorder all fields that are zero initialized to happen in sequence
Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr
Milestone: -

@kunalspathak
Copy link
Member

Good cleanup..lets see how TP reacts to it.

kunalspathak
kunalspathak approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

@jakobbotsch jakobbotsch marked this pull request as ready for review February 10, 2023 10:14
@jakobbotsch
Copy link
Member Author

Failure is #75244

@jakobbotsch jakobbotsch merged commit c16c736 into dotnet:main Feb 10, 2023
@jakobbotsch jakobbotsch deleted the lsra-tp branch February 10, 2023 10:14
@build-analysis build-analysis bot mentioned this pull request Feb 10, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakobbotsch @kunalspathak