Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to preview 1 #82652

Closed
wants to merge 1 commit into from
Closed

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Feb 25, 2023

Fixes #82583

The slowdowns was being caused by a crash in VBCSCompiler. The process was resilient
to these crashes, but the cached state gets destroyed and the slowness was a
symptom. The crash was when trying to destroy thread statics of dynamic classes
on a collectible module for a thread destroy path. To do this, it checks all
the dynamic entries in the TLM and frees both GC and non-GC statics. The SDK
currently being used doesn't contain #80822 which 0-initializes the entry.
Without this, we try to free a static that doesn't exist and we crash.

@ghost ghost assigned hoyosjs Feb 25, 2023
@hoyosjs
Copy link
Member Author

hoyosjs commented Feb 25, 2023

cc: @jaredpar @jcouv

@jaredpar
Copy link
Member

jaredpar commented Feb 25, 2023

I think you're likely blocked from upgrading Roslyn until the following issues are addressed:

@lewing as he was tracking the new roslyn insertion

@lewing
Copy link
Member

lewing commented Feb 25, 2023

we ifdefed the parameter test for the moment but I don't think we should update roslyn again unless we have reason to believe #82467 has been resolved

@jaredpar
Copy link
Member

@lewing #82467 has not been resolved yet. I'm still trying to root cause what the problem is. Using #82615 to track down the issue.

Think I have found the culprit but want to see several green builds before I feel confident about it.

@hoyosjs hoyosjs changed the title Update SDK to preview 1 and upgrade roslyn again Update SDK to preview 1 Feb 25, 2023
@lewing
Copy link
Member

lewing commented Feb 25, 2023

needs the fixes in #82599 and whatever is missing (we should probably just take the arcade bump)

@hoyosjs
Copy link
Member Author

hoyosjs commented Feb 25, 2023

Closing in favor of that one. The upgrade already happens there anyway.

@hoyosjs hoyosjs closed this Feb 25, 2023
@hoyosjs hoyosjs deleted the juhoyosa/bump-sdk branch February 25, 2023 01:27
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library and Tools Subset build times regression (50+% increase)
5 participants