Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Revert "Pin the Alpine Arm32 image to previous tag (#94683)" #95410

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 29, 2023

Backport of #95359 to release/8.0-staging

/cc @CarnaViire

Customer Impact

This is a test-only (infra-only) change.

This brings back the rolling "latest" image for Alpine Arm 32.

While pinning the image in #94609 mitigated the issue for System.Net.Quic tests, it was only temporary, as it prevents us from consuming any updates from the image.

Now, Quic issue was mitigated in a different way within the image itself, so it is safe to revert the pinning. And it will also allow us to fix dotnet/dnceng#1423.

Testing

CI (System.Net.Quic tests execute successfully on Alpine Arm 32)

Risk

N/A (test-only change)

cc @carlossanlop @hoyosjs @wfurt @ManickaP

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 29, 2023
@ghost
Copy link

ghost commented Nov 29, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #95359 to release/8.0-staging

/cc @CarnaViire

Customer Impact

This is a test-only (infra-only) change.

This brings back the rolling "latest" image for Alpine Arm 32.

While pinning the image in #94609 mitigated the issue for System.Net.Quic tests, it was only temporary, as it prevents us from consuming any updates from the image.

Now, Quic issue was mitigated in a different way within the image itself, so it is safe to revert the pinning. And it will also allow us to fix dotnet/dnceng#1423.

Testing

CI (System.Net.Quic tests execute successfully on Alpine Arm 32)

Risk

N/A (test-only change)

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure, needs-area-label

Milestone: -

@CarnaViire CarnaViire removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 29, 2023
@CarnaViire
Copy link
Member

CarnaViire commented Nov 30, 2023

Test-only change, approved by area owners, CI is green. Adding the approved label & merging.

@CarnaViire CarnaViire added the Servicing-approved Approved for servicing release label Nov 30, 2023
@CarnaViire CarnaViire merged commit 015e954 into release/8.0-staging Nov 30, 2023
101 of 106 checks passed
@CarnaViire CarnaViire deleted the backport/pr-95359-to-release/8.0-staging branch November 30, 2023 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants