Fixes issue #9807 REVIEW (2nd) AFTER #12221 merged DRAFT

[paul1956]

Fixes #9807

Proposed changes

• Add Remove dependance on WebClient for VB FileDownload by using HttpClient
• Add a Visual Basic Scratch Project so that Microsoft.VisualBasic.Forms dependent code can be tested from a Visual Basic project (even an empty WinForms project written in VB does not work)
• Upload still uses WebClient that also needs to be done as a separate PR

Customer Impact

Adds Async file download support to VB, and if WebClient goes away this will allow existing Visual Basic programs using synchronous File Download to still work.
It also enable Async NetworkDownload is API is approved

Regression?

• Yes when WebClient if and when goes away, no today

Risk

• The code as is completely untested as I can't test without a working Scratch Project.
• The existing code uses ICredentials in some of the paths, it is unclear how compatible that is between WebClient and HttpClient

Test methodology

Close to 100% Code Coverage Before and After change, original tests had no tests and there Error Message handling was odd

There are Exception Messages that need to move from WebClient to this PR and be translated.

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Attention: Patch coverage is 95.44264% with 87 lines in your changes missing coverage. Please review.

Project coverage is 75.79110%. Comparing base (21f6a05) to head (08df5f8).

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #11867         +/-   ##
===================================================
+ Coverage   75.69745%   75.79110%   +0.09364%     
===================================================
  Files           3151        3155          +4     
  Lines         635600      637344       +1744     
  Branches       46951       47025         +74     
===================================================
+ Hits          481133      483050       +1917     
+ Misses        151036      150853        -183     
- Partials        3431        3441         +10     

Flag	Coverage Δ
Debug	75.79110% <95.44264%> (+0.09364%)	⬆️
integration	18.15091% <0.00000%> (-0.11644%)	⬇️
production	49.36994% <84.15301%> (+0.12906%)	⬆️
test	97.06217% <100.00000%> (+0.01163%)	⬆️
unit	46.46063% <84.15301%> (+0.24080%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.