Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds code coverage to FormatStringDialog #12185

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Adds code coverage to FormatStringDialog #12185

merged 1 commit into from
Sep 25, 2024

Conversation

ricardobossan
Copy link
Member

@ricardobossan ricardobossan commented Sep 19, 2024 •
edited by dotnet-policy-service bot
Loading

Related #10773

Proposed changes

  • Adds code coverage for FormatStringDialog.

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests

Test environment(s)

  • 9.0.100-rc.1.24452.12
Microsoft Reviewers: Open in CodeFlow

@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Sep 19, 2024
@ricardobossan ricardobossan self-assigned this Sep 19, 2024
@ricardobossan ricardobossan requested a review from a team as a code owner September 19, 2024 22:57
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.42387%. Comparing base (34dc978) to head (28d5a49).
Report is 27 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12185         +/-   ##
===================================================
+ Coverage   75.28764%   75.42387%   +0.13622%     
===================================================
  Files           3097        3102          +5     
  Lines         634294      634400        +106     
  Branches       46876       46883          +7     
===================================================
+ Hits          477545      478489        +944     
+ Misses        153339      152490        -849     
- Partials        3410        3421         +11
Flag Coverage Δ
Debug 75.42387% <92.06349%> (+0.13622%) ⬆️
integration 17.98029% <ø> (+0.17729%) ⬆️
production 48.80094% <ø> (+0.23480%) ⬆️
test 97.02672% <92.06349%> (-0.00060%) ⬇️
unit 45.81270% <ø> (+0.06020%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 20, 2024
@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_To_FormatStringDialog branch from e24f136 to d8ed7b4 Compare September 23, 2024 08:08
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 23, 2024
@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Sep 23, 2024
@ricardobossan ricardobossan mentioned this pull request Sep 23, 2024
Open
@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_To_FormatStringDialog branch from d8ed7b4 to c85431f Compare September 24, 2024 14:24
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 24, 2024
Adds code coverage for FormatStringDialog
28d5a49 
Related dotnet#10773

## Proposed changes

- Adds code coverage for `FormatStringDialog`.

## Customer Impact

- None

## Regression?

- No

## Risk

- Minimal

## Test methodology

- Unit tests

## Test environment(s)

- 9.0.100-rc.1.24452.12
@ricardobossan ricardobossan force-pushed the Issue_10773_Add_Code_Coverage_To_FormatStringDialog branch from c85431f to 28d5a49 Compare September 24, 2024 18:04
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 24, 2024
@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Sep 24, 2024
lonitra
lonitra approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit d4e6f9d into dotnet:main Sep 25, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 25, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Sep 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Epica3055 Epica3055 Epica3055 left review comments

@lonitra lonitra lonitra approved these changes

@SimonZhao888 SimonZhao888 Awaiting requested review from SimonZhao888

@Tanya-Solyanik Tanya-Solyanik Awaiting requested review from Tanya-Solyanik

@LeafShi1 LeafShi1 Awaiting requested review from LeafShi1

Assignees

@ricardobossan ricardobossan

Labels
None yet
Projects
None yet
Milestone
10.0 Preview1
Development

Successfully merging this pull request may close these issues.
5 participants
@ricardobossan @Tanya-Solyanik @lonitra @LeafShi1 @Epica3055