test(audio): improve coverage of validate prompt and media

dottxt-ai · Dec 11, 2024 · b529821 · b529821
1 parent d7d6b65
commit b529821
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/outlines/generate/api.py b/outlines/generate/api.py
@@ -691,8 +691,11 @@ def _validate_prompt_media_types(
         def valid_types(prompts, media):
             import numpy as np  # type: ignore
 
-            if not isinstance(prompts, (str, list)):
-                return False
+            if not isinstance(prompts, str):
+                if not isinstance(prompts, list):
+                    return False
+                if not all(isinstance(p, str) for p in prompts):
+                    return False
             if not isinstance(media, list):
                 return False
             if not all(isinstance(m, np.ndarray) for m in media):

diff --git a/tests/generate/test_api.py b/tests/generate/test_api.py
@@ -42,6 +42,8 @@ def test_vision_sequence_generator_validate_types(prompts, media, type_error):
     "prompts,media,type_error",
     [
         ("single prompt", [AUDIO_ARRAY], False),
+        (0, [AUDIO_ARRAY], True),
+        ([AUDIO_ARRAY], "single prompt", True),
         (["single prompt"], [AUDIO_ARRAY], False),
         (["prompt0", "prompt1"], [AUDIO_ARRAY, AUDIO_ARRAY], False),
         ("single prompt", [AUDIO_ARRAY, AUDIO_ARRAY], False),