Handle enum in choice #1279
Merged
Handle enum in choice #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-prz
force-pushed
the
handle-enum-in-choice
branch
4 times, most recently
from
559b2d6 to
2a0aa9b
Compare
g-prz
commented
Nov 28, 2024
Comment on lines
+27
to
+28
| if isinstance(choices, type(Enum)): | ||
| generator.format_sequence = lambda x: pyjson.loads(x) |
There was a problem hiding this comment.
Hey @rlouf 🙋♂️
I have a design related question: in case we pass an enum to choice, are we expecting to return an instance of that enum or only its value? If the latter we are fine, if the former we need to reconstruct the enum in here
Thx 🙏
There was a problem hiding this comment.
Not sure what you mean but returning the instance, but we definitely just want the value.
There was a problem hiding this comment.
We are good for review then
g-prz
force-pushed
the
handle-enum-in-choice
branch
from
6137dae to
8090ad1
Compare
|
Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at solving #1218 (requires #1277 to be merged)
Quick fix to solve #1275