Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in vllm extra requirements #1315

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Conversation

chicham
Copy link
Contributor

@chicham chicham commented Dec 3, 2024

Fixes #1314

🚧 Thank you for opening a PR!

A few important guidelines and requirements before we can merge your PR:

  • We should be able to understand what the PR does from its title only;
  • There is a high-level description of the changes;
  • If I add a new feature, there is an issue discussing it already;
  • There are links to all the relevant issues, discussions and PRs;
  • The branch is rebased on the latest main commit;
  • Commit messages follow these guidelines;
  • One commit per logical change;
  • The code respects the current naming conventions;
  • Docstrings follow the numpy style guide;
  • pre-commit is installed and configured on your machine, and you ran it before opening the PR;
  • There are tests covering the changes;
  • The documentation is up-to-date;

Consider opening a Draft PR if your work is still in progress but you would
like some feedback from other contributors.

@rlouf
Copy link
Member

rlouf commented Dec 4, 2024

Good find, thank you for submitting a fix!

@rlouf rlouf merged commit dccaace into dottxt-ai:main Dec 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in vllm extra requirements
2 participants