[MLX] [bugfix] Preserve dtype of array when converting to torch #1349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticing the following error with a recent version of outlines when used with MLX:
The issue is that the MLX array of tokens, which are integers, are being force-converted to floats, even though outlines expects an integer array. This is because all MLX arrays are being converted to
float32
, even when it's not necessarily appropriate, like in this case. Looking at the commented link, the advice was to convert tofloat32
only forbfloat16
, because numpy does not supportbfloat16
. Now the MLX_to_torch
implementation matches the other array libraries, none of the other libraries are being force-casted to float