Use http datasource for local urls #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all local urls are retrieved by the
DefaultDataSourceFactory
. However, in my case I want to use localhost urls that return a redirect (302) to the actual mp3.Therefore, since they are http/https urls, they should be handled by
DefaultHttpDataSource
so the redirect is followed.This PR fixes the check
isLocalUri
to match local file uris only.I have tested this with React Native Track Player.