New/task similarity #429
Merged
New/task similarity #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update to improve rubocop linting
Ensure that actions can be retried on failue. The new TII Submission class allows the status of the submission to be tracked and used to determine the next action. The user table is updated to record the user's eula status.
to ensure bad auth triggers relogin in frontend.
…fire-api into new/task-similarity
- load from tii host - only require eula if needed - initialise on load - ensure tests work
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| get "/api/tasks/#{task.id}/similarities/#{sim.id}/viewer_url" | ||
| assert_equal 200, last_response.status | ||
| assert last_response.body.include? "https://viewer.url" |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
macite
pushed a commit
to macite/doubtfire-api
that referenced
this pull request
Nov 30, 2023
…larity New/task similarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge nts into development to ensure development IS the current development branch