Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Numbas updated with polymorphic association #445

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

satikaj
Copy link
Contributor

@satikaj satikaj commented Sep 8, 2024

Description

Latest commit introduces polymorphic association to task comments. Currently, task comments can belong to either Scorm test attempts or Overseer assessments.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests passed. Comments display as usual in the frontend.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if appropriate
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have created or extended unit tests to address my new additions
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@macite macite changed the base branch from 8.0.x to new/scorm September 24, 2024 00:53
Copy link
Member

@macite macite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking super close - the Task Comment table is huge, so I think we can optimise the update... see the comment. @satikaj do you have time to make these changes?

@macite macite merged commit de4b33a into doubtfire-lms:new/scorm Oct 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants