Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pywal integration to README #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aryakaul
Copy link

@aryakaul aryakaul commented Nov 4, 2019

Hello! I love your application, and I wrote a simple tool to update colorscheme through pywal.

@dpayne
Copy link
Owner

dpayne commented Nov 5, 2019

Love it! Pywal is a great project and this seems to work. Your script is interesting and I have a couple questions about it.

This line is probably the one that stands out the most to me

# use brightness scale for later sorting (from here http://alienryderflex.com/hsp.html)
n=$(echo "sqrt(0.299*$r^2+0.114*$b^2+0.587*$g^2)" | bc -l)

From this it seems like the script is calculating a brightness score then sorting the results. I assume this is to create a better gradient from high to low, but please let me know if that is incorrect. I like this idea a lot, do you think it is worth porting to the code directly? The configuration would be option colors.sort=(none|brightness_desc|brightness_asc). It might make it easier for people not using pywal, and even the pywal I think would just be a template.

@aryakaul
Copy link
Author

aryakaul commented Nov 6, 2019

Yep, you're right the idea is to help make a more pleasing gradient.

I think the idea is worth porting to the code, and should be relatively simple to implement. I'd be happy to help add this feature if you can point me in the right direction with the vis codebase!

@dpayne
Copy link
Owner

dpayne commented Nov 6, 2019

It would make the most sense to add a function call right after reading the list of colors that then sorts the vector. Here is the line the reads the colors https://github.com/dpayne/cli-visualizer/blob/master/src/Utils/ConfigurationUtils.cpp#L350.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants