Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added package/ckeditor-fakeobjects in repositories #216

Conversation

gargsuchi
Copy link
Contributor

When trying to install tide locally, composer gives this error:

  • dpc-sdp/tide_core 2.0.4 requires ckeditor/fakeobjects ^4.5.11 -> no matching package found

This PR fixes the error.

@barbun
Copy link
Contributor

barbun commented Apr 14, 2021

@gargsuchi good stuff :)

It seems that the PR pins the package version to 4.5.11, all while composer.json constrains it only to non-breaking updates ^4.5.11. I am not sure how critical this is but it is probably a good practice to stick to non-breaking updates, especially when other packages are also set to use version range.

From here, I guess there's at least 2 options:

  • Lock the version in composer.json to 4.5.11
  • Switch to "drupal-ckeditor-libraries-group/fakeobjects": "^4.5.11" which seems to be mirroring CKEditor updates.

@barbun
Copy link
Contributor

barbun commented Apr 29, 2021

Enhanced on this in #229. I reckon this PR can be closed then :)

@gargsuchi
Copy link
Contributor Author

Closing in favour of #229 @barbun

@gargsuchi gargsuchi closed this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants