[SD-345] Implement Ability to Remove Quick Exit from Specific Site Sections

[sharmasahil]

Jira

SD-345 - Implement Ability to Remove Quick Exit from Specific Site Sections

Changes

Added new field in sites taxonomy as 'Show Exit Site Specific?' only visible if its a sub-site.

[vincent-gao]

hey @sharmasahil ,
thanks for the changes.
but please update the PR title to follow the format below and ensure it’s clear and meaningful.
e.g. [SD-345] Add Site-Specific “Quick Exit” Button Field to Sites Taxonomy

details of the PR

### Jira
https://digital-vic.atlassian.net/browse/SD-345

### Changes
.........

[vincent-gao]

hey @sharmasahil please see my comments.

[sharmasahil]

hey @sharmasahil , thanks for the changes. but please update the PR title to follow the format below and ensure it’s clear and meaningful. e.g. [SD-345] Add Site-Specific “Quick Exit” Button Field to Sites Taxonomy

details of the PR

### Jira
https://digital-vic.atlassian.net/browse/SD-345

### Changes
.........

Done

[vincent-gao]

@sharmasahil the title~

change it from Feature/sd 345 quick exit to [SD-345] Implement Ability to Remove Quick Exit from Specific Site Sections
I have changed it for you.

[vincent-gao]

hey @sharmasahil some issues,

1. The tests have failed. Please review the details here https://github.com/dpc-sdp/tide_core/actions/runs/11360325150/job/31597880122?pr=524 .
   • https://github.com/dpc-sdp/dev-tools/blob/master/.ahoy.yml#L165 may help.
2. Please try to install the tide_core module locally and then enable the tide_site module. Once installed, run the behat tests for both tide_site and tide_core. For more details on setting up and running tests, refer to the development and maintenance guide.
   • The reason I’m requesting this is that we currently don’t have a way to automate testing for submodules. To be safe, please perform manual testing for now. The issue with automating these tests will be addressed in a future sprint.

[sharmasahil]

hey @sharmasahil some issues,

1. The tests have failed. Please review the details here https://github.com/dpc-sdp/tide_core/actions/runs/11360325150/job/31597880122?pr=524 .

   • https://github.com/dpc-sdp/dev-tools/blob/master/.ahoy.yml#L165 may help.

2. Please try to install the tide_core module locally and then enable the tide_site module. Once installed, run the behat tests for both tide_site and tide_core. For more details on setting up and running tests, refer to the development and maintenance guide.

   • The reason I’m requesting this is that we currently don’t have a way to automate testing for submodules. To be safe, please perform manual testing for now. The issue with automating these tests will be addressed in a future sprint.

This is fixed Vincent and also behat test require fix as discussed.

[MdNadimHossain]

@seanhamlin thanks for making the changes. The only thing I am requesting is changing the var name in js for the parent field. Have a look. Thanks

[MdNadimHossain]

wrong indention, It has once extra space

[MdNadimHossain]

wrong indention

[MdNadimHossain]

Instead of using parent, which is a common jQuery method, use a more descriptive variable name like parentField to avoid confusion.

[sharmasahil]

@seanhamlin thanks for making the changes. The only thing I am requesting is changing the var name in js for the parent field. Have a look. Thanks

@MdNadimHossain This is fixed Nadim, Thanks!!

[vincent-gao]

hey @sharmasahil could you please fix the linting issues, more details https://github.com/dpc-sdp/tide_core/actions/runs/11397035111/job/31711837299?pr=524