-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SD-345] Implement Ability to Remove Quick Exit from Specific Site Sections #524
base: develop
Are you sure you want to change the base?
Conversation
hey @sharmasahil , details of the PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @sharmasahil please see my comments.
Done |
@sharmasahil the title~ |
hey @sharmasahil some issues,
|
* added validation to current user
This is fixed Vincent and also behat test require fix as discussed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanhamlin thanks for making the changes. The only thing I am requesting is changing the var name in js for the parent field. Have a look. Thanks
modules/tide_site/tide_site.install
Outdated
* New field site specific quick exit button. | ||
*/ | ||
|
||
function tide_site_update_10002() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong indention, It has once extra space
modules/tide_site/tide_site.install
Outdated
$update_service->revert($type, $configs_name); | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong indention
modules/tide_site/js/quick_exit.js
Outdated
|
||
Drupal.behaviors.siteQuickExitFields = { | ||
attach: function (context, settings) { | ||
var parent = ($('.taxonomy-term-sites-form #edit-parent')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using parent, which is a common jQuery method, use a more descriptive variable name like parentField to avoid confusion.
@MdNadimHossain This is fixed Nadim, Thanks!! |
hey @sharmasahil could you please fix the linting issues, more details https://github.com/dpc-sdp/tide_core/actions/runs/11397035111/job/31711837299?pr=524 |
Jira
SD-345 - Implement Ability to Remove Quick Exit from Specific Site Sections
Changes
Added new field in sites taxonomy as 'Show Exit Site Specific?' only visible if its a sub-site.