reorder parameters

[yeniatencio]

Jira

Problem/Motivation

Content-vic and other projects are having behat test failied because of optional parameter $time declared before required parameter $alias_helper.

Fix

Reorder parameters
Initialize the $aliasHelper property of the current class with a service that helps manage alias storage, allowing the class to use this service for its functionality.
assigns the aliasHelper property to the service tide_site.alias_storage_helper to allow the class to use the alias storage.

Related PRs

https://github.com/dpc-sdp/content-vic-gov-au/pull/1725

Screenshots

TODO

[sharmasahil]

@yeniatencio I have also tried this fix but din't work in local, so please confirm if you have ran behat tests locally and its successful after this fix.

[yeniatencio]

@yeniatencio I have also tried this fix but din't work in local, so please confirm if you have ran behat tests locally and its successful after this fix.

Tested locally and pr branch in content-vic. I have added the pr link and a screenshot to prove that.

[vincent-gao]

Using $this->aliasHelper = \Drupal::service('tide_site.alias_storage_helper') isn’t ideal because it bypasses dependency injection, making the code harder to test.

The original error,

      8192: Optional parameter $time declared before required parameter $alias_helper is implicitly treated as a required parameter in docroot/modules/contrib/tide_core/modules/tide_site/src/AliasManager.php line 29 (Drupal\Core\Entity\EntityStorageException)

happened because required parameters must come before optional ones.
try to move AliasStorageHelper $alias_helper before $time

[yeniatencio]

Using $this->aliasHelper = \Drupal::service('tide_site.alias_storage_helper') isn’t ideal because it bypasses dependency injection, making the code harder to test.

The original error,

      8192: Optional parameter $time declared before required parameter $alias_helper is implicitly treated as a required parameter in docroot/modules/contrib/tide_core/modules/tide_site/src/AliasManager.php line 29 (Drupal\Core\Entity\EntityStorageException)

happened because required parameters must come before optional ones. try to move AliasStorageHelper $alias_helper before $time

@vincent-gao , That was my first thought too. You can see in the first commit I have done what you are suggesting and it doesn't fix the issue. 16c32f8

[vincent-gao]

😢