Add message about Convergence #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add message to gpu spectra
add message about convergence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi SPECTRA team! This PR is a small suggestion to add a status message after training to indicate that its ok if the model converges early. Since the the progress bar is there, it can look like an error occurred if it stops processing at say 12% without any message. It looks like this confusion has been reported before. An alternative would be updating the docs and maybe renaming
num_epochstomax_epochsto imply that its expected that a solution will be reached sooner.Happy to change the message to whatever you think is the most appropriate!