filter ip addresses

lib/network_resiliency.rb

@@ -52,6 +52,25 @@ def timestamp
     Process.clock_gettime(Process::CLOCK_MONOTONIC) * 1_000
   end
 
+  # private
+
+  IP_ADDRESS_REGEX = Regexp.new(/\d{1,3}(\.\d{1,3}){3}/)
+
+  def record(adapter:, action:, destination:, duration:, error: nil)
+    # filter raw IP addresses
+    return if IP_ADDRESS_REGEX.match?(destination)
+
+    NetworkResiliency.statsd&.distribution(
+      "network_resiliency.#{action}",
+      duration,
+      tags: {
+        adapter: adapter,
+        destination: destination,
+        error: error,
+      }.compact,
+    )
+  end
+
   def reset
     @enabled = nil
   end

lib/network_resiliency/adapter/http.rb

@@ -27,14 +27,12 @@ def connect
           ensure
             ts += NetworkResiliency.timestamp
 
-            NetworkResiliency.statsd&.distribution(
-              "network_resiliency.connect",
-              ts,
-              tags: {
-                adapter: "http",
-                destination: address,
-                error: e&.class,
-              }.compact,
+            NetworkResiliency.record(
+              adapter: "http",
+              action: "connect",
+              destination: address,
+              error: e&.class,
+              duration: ts,
             )
           end
         end

spec/http_spec.rb

@@ -95,5 +95,15 @@
         end
       end
     end
+
+    context "when host is a raw IP address" do
+      let(:http) { Net::HTTP.new("127.0.0.1") }
+
+      it "does not call datadog" do
+        expect(NetworkResiliency.statsd).not_to receive(:distribution)
+
+        http.connect
+      end
+    end
   end
 end

spec/network_resiliency_spec.rb

@@ -95,4 +95,47 @@ def expect_enabled
       expect_enabled.to be false
     end
   end
+
+  describe ".record" do
+    subject do
+      NetworkResiliency.record(
+        adapter: "adapter",
+        action: action,
+        destination: host,
+        duration: duration,
+        error: error,
+      )
+
+      NetworkResiliency.statsd
+    end
+
+    let(:action) { "connect" }
+    let(:error) { Net::OpenTimeout }
+    let(:duration) { 10 }
+    let(:host) { "example.com" }
+
+    before do
+      allow(NetworkResiliency.statsd).to receive(:distribution)
+    end
+
+    it "calls Datadog" do
+      is_expected.to have_received(:distribution)
+    end
+
+    it "captures metric info" do
+      is_expected.to have_received(:distribution).with(
+        "network_resiliency.#{action}",
+        duration,
+        tags: include(destination: host, error: error),
+      )
+    end
+
+    context "when host is a raw IP address" do
+      let(:host) { "127.0.0.1" }
+
+      it "does not call Datadog" do
+        is_expected.not_to have_received(:distribution)
+      end
+    end
+  end
 end