fix: improve performance for get role permissions (#1624)

dpgaspar · Apr 26, 2021 · 5a76618 · 5a76618
1 parent 159de35
commit 5a76618
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/flask_appbuilder/security/sqla/manager.py b/flask_appbuilder/security/sqla/manager.py
@@ -4,6 +4,7 @@
 
 from sqlalchemy import and_, func, literal
 from sqlalchemy.engine.reflection import Inspector
+from sqlalchemy.orm import contains_eager
 from sqlalchemy.orm.exc import MultipleResultsFound
 from werkzeug.security import generate_password_hash
 
@@ -369,6 +370,8 @@ def get_db_role_permissions(self, role_id: int) -> List[PermissionView]:
             .join(ViewMenu)
             .join(PermissionView.role)
             .filter(Role.id == role_id)
+            .options(contains_eager(PermissionView.permission))
+            .options(contains_eager(PermissionView.view_menu))
             .all()
         )