-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support sqlalchemy 2.x and flask-sqlalchemy 3 (breaking) #2241
base: master
Are you sure you want to change the base?
Conversation
Related: #2240 |
This reverts commit 9b19585.
@dpgaspar thank you so much for working on this! I plan on running some tests on this and will report back. |
Hi, @dpgaspar , just curious if there are any new process to upgrade to flask-sqlalchemy>3.0? |
@@ -94,7 +95,6 @@ class AppBuilder: | |||
def __init__( | |||
self, | |||
app: Optional[Flask] = None, | |||
session: Optional[SessionBase] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
session
was removed from arguments but need to be removed from docstring too
@dpgaspar Is this PR ready for merge and release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran Flask-AppBuilder in this branch and it seems everything is fine, there is only the issue of the field_flags attribute, for which I have already submitted the pull request #2294.
Description
ADDITIONAL INFORMATION