Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PKGBUILD for building on Arch Linux #138

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

LupertEverett
Copy link
Contributor

It builds on my machine:tm: :V

Ideally this should be on AUR but it probably won't hurt to have it here too.

(Please do tell if I'm missing something here)

PKGBUILD Show resolved Hide resolved
PKGBUILD Show resolved Hide resolved
@sharkwouter
Copy link
Contributor

Hey @LupertEverett I took a quick look. I know I'm not a big contributor to this project, but I have some experience with packaging. I hope my review is appreciated. I added some comments on what I think could be added to make the package better, but I do think it is a good looking PKGBUILD already.

@LupertEverett
Copy link
Contributor Author

Hey @LupertEverett I took a quick look. I know I'm not a big contributor to this project, but I have some experience with packaging. I hope my review is appreciated. I added some comments on what I think could be added to make the package better, but I do think it is a good looking PKGBUILD already.

Thanks for your suggestions! This is literally the first time I've dabbled with PKGBUILDs (honestly all I did here was checking how others made em lol) so any help is appreciated!

Copy link
Contributor

@sharkwouter sharkwouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, good work

@dpjudas dpjudas merged commit 6fec0e4 into dpjudas:master Oct 9, 2024
4 checks passed
@dpjudas
Copy link
Owner

dpjudas commented Oct 9, 2024

OK merging it then. Thanks for looking into it sharkwouter. :)

@LupertEverett LupertEverett deleted the archpkg branch October 9, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants