Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add docker group to dependabot config #229

Closed
wants to merge 1 commit into from
Closed

ci: add docker group to dependabot config #229

wants to merge 1 commit into from

Conversation

afuetterer
Copy link
Contributor

No description provided.

@cmil
Copy link
Member

cmil commented Dec 19, 2023

What does this do?

@afuetterer
Copy link
Contributor Author

The dependabot will send you a PR, if there is a newer version of the docker base image.

Like "Updates eclipse-temurin from 8-jre to 21-jre"
See: https://github.com/afuetterer/dracor-api/pull/14

Is 21-jre compatible?

@cmil
Copy link
Member

cmil commented Dec 22, 2023

I think in our case that would only make sense if dependabot could suggest a JRE version that is guaranteed to work with eXist DB. I'm not sure we can simply upgrade to the latest JRE. Until now I have been following the image version used in https://github.com/peterstadler/existdb-docker/blob/main/Dockerfile which our Dockerfile was derived from, which is why we are still running 8-jre at the moment. That may be more conservative than necessary, though. The eXist documentation gives Java 8 as the minimum requirement but doesn't seem to exactly say what's the latest supported Java version. A short search at the eXist repo reveals that they are using JDK 17 in a lot of places. So an upgrade to eclipse-temurin:21-jre may indeed be premature.

@afuetterer
Copy link
Contributor Author

Alright, if there is no way to test the functionality of the docker container (and thus the image is working), then I will close this PR.

@afuetterer afuetterer closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants