Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend API tests #237

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Extend API tests #237

merged 7 commits into from
Jan 29, 2024

Conversation

cmil
Copy link
Member

@cmil cmil commented Jan 7, 2024

This PR adds documentation for possible 404 responses, sets up a test instance that can be started in parallel to a development one (port 8081), and runs all test types except status_code_conformance. The latter still yields several undocumented 400 Bad request responses.

see #236

cmil added 3 commits January 7, 2024 19:10
The `status_code_conformance` check is the last one that fails (for GET requests).
@cmil cmil force-pushed the 236-extend-tests branch from f1ad1ef to 93db5cf Compare January 7, 2024 18:35
@afuetterer
Copy link
Contributor

There are five check groups of which you use four.
You can also use a reverse approach and use "--exclude-checks" if you like.

@cmil cmil marked this pull request as draft January 8, 2024 09:25
@cmil
Copy link
Member Author

cmil commented Jan 8, 2024

There are five check groups of which you use four.
You can also use a reverse approach and use "--exclude-checks" if you like.

Thanks for the hint. The goal is to eventually use all checks. Right now there are still tests failing if we do that, which is why I put the PR in draft mode. I'll try to improve this as soon as time allows.

@cmil cmil marked this pull request as ready for review January 29, 2024 00:27
@cmil cmil merged commit 96f49ba into main Jan 29, 2024
1 check passed
@cmil cmil deleted the 236-extend-tests branch January 29, 2024 00:28
@afuetterer
Copy link
Contributor

Very nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants