Restructure database file hierarchy #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new structure puts all files (tei, rdf, metrics, sitelinks) for
an individual play into a single collection instead of spreading them
over different type specific collections with sub paths for each
corpus. This makes it much easier to delete a single play or an
entire corpus since we no longer need to do housekeeping in several
collections with a delete trigger.
db
|- dracor
|- corpora
|- ger
| |- lessing-emilia-galotti
| | |- tei.xml
| | |- metrics.xml
| | |- rdf.xml
| | |- sitelinks.xml
| |- zschokke-abellino
| |- ...
|- als
|- ita
|- ...
The function now removes the entire corpus collection instead of iterating over each TEI file. Solves #221
cmil
force-pushed
the
restructure-file-hierarchy
branch
from
ac88e9c to
44ac7b1
Compare
cmil
force-pushed
the
restructure-file-hierarchy
branch
from
44ac7b1 to
f3c720f
Compare
cmil
added a commit
to dracor-org/testdracor
that referenced
this pull request
Feb 17, 2024
Testing removal with webhook after refactoring of dracor-org/dracor-api#240.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new structure puts all files (tei, rdf, metrics, sitelinks) for an individual play into a single collection instead of spreading them over different type specific collections with sub paths for each corpus. This makes it much easier to delete a single play or an entire corpus since we no longer need to do housekeeping in several collections with a delete trigger.
The new structure looks similar to this: