Rendered whitespace in selection hard to read

[beeb]

When displaying whitespace characters in the selected code via editor.renderWhitespace: selection (which is the new default, by the way), the characters are hard to see. Pictured here is Python source code.

Dracula:

Dracula Soft:

Not sure how feasible it would be to update editorWhitespace.foreground to add some contrast without it looking ugly when unselected.

[dsifford]

Open to suggestions you might have, but this is sort of an unfortunate result of how vscode layers their highlights.

See #61 (comment)

(theres a few more issues where there's discussion about highlight over comments with a similar sentiment as well)

[beeb]

Is there a way to easily try different colors on my end? Or do I need to clone the repo and install a local version or something? I'm not too familiar with VSCode extensions

[dsifford]

@beeb see here: https://code.visualstudio.com/api/references/theme-color

[beeb]

Thanks! I found that #3b3b3b is just about where the symbols are visible both when unselected and selected. There are possible variations in saturation that work as well, like #3a3b3d maybe.

You might consider changing the indent guides color to the same shade too (didn't do it in the screenshot below)

[beeb]

Additional option: use transparency, for instance #ffffff1f which gives this:

To be honest this gives very good readability both in selected and unselected state.

[leandrocunha]

I opened a PR for this improvement, really useful suggestion

[beeb]

Fixed by #135