Highlight color of comments is hard to read

[teddybradford]

The find highlight color, selection highlight color, and selection highlight of a find highlighted color for comments are a bit difficult to read. Maybe they should be adjusted to improve readability?

[dsifford]

I agree. It's a tricky situation though because VSCode stacks highlight color matches. So, for example, if editor.selectionBackground has some color with 50% opacity and editor.selectionHighlightBackground has some color with 50% opacity, the end result is two layers totaling 75% opacity over top of the text layer.

Feel free to open a PR if you've got any ideas.

[jbpotonnier]

Maybe add a border can help editor.selectionHighlightBorder

[fungilation]

Just use a different background color that's contrasting to font color, while still a harmonious color of course. Like a soft shade of orange.

[dsifford]

Not possible to specify highlight background color based on semantics. It's a one-shot deal. So if background color is orange then the highlight color across the board will be orange. That also still leaves the issue of multiple overlaying highlight colors as described above.

[beeb]

Similar to my other issue #134 , one could change the comments color to a lighter shade with reduced opacity, e.g. #8aa1e59b which gives:

This is just the principle, the actual color theory behind I'm not so familiar with but I think you should be able to manage to achieve the exact same result (unselected) as the original solid color, while the selected shades will be improved.

EDIT: closest I could get is #839be5a0 when on background #282a36.

[MaddyGuthridge]

Just bumping to ask if there's going to be a fix for this? To me, it looks like selections are exactly the same colour as the highlights that VS Code does for matching words. Any guesses on which ones of these I have selected and which ones are highlighted? I'm not even sure anymore and I was the one that made the selections.