Adjust onSettle index of BottomSheet #946
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sieu-db
changed the title
|
Published version: @draftbit/[email protected] |
| @@ -109,7 +109,7 @@ const BottomSheet = React.forwardRef<BottomSheetComponent, BottomSheetProps>( | |||
| borderWidth, | |||
| borderColor: borderColor ?? theme.colors.border.brand, | |||
| }} | |||
| onChange={(index) => onSettle?.(mappedSnapPoints.length - index - 1)} | |||
| onChange={(index) => onSettle?.(index)} | |||
There was a problem hiding this comment.
I don't think this is the issue. Looking at the linear issue (and testing on my own), seems the bottom sheet has 4 snap points, even though by default there should only be 3 (top, middle, bottom). I think this inconsistency is what is leading to the incorrect index, but the existing logic for this is still correct.
There was a problem hiding this comment.
Seems there's always an additional snap point for some reason, hmm..
There was a problem hiding this comment.
I can investigate this later today, but let me know if you have any idea why this could be happening.
There was a problem hiding this comment.
Ya, I will investigate more today 🙏 thanks for point out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Demo
Screen.Recording.2024-08-28.at.18.08.39.mov
Summary:
Updated
BottomSheetcomponent to use the index directly inonChangeand added logging inBottomSheetExample.Key points:
onChangeinpackages/core/src/components/BottomSheet/BottomSheet.tsxto use the index directly.onChange.onSettlecallback inexample/src/BottomSheetExample.tsxto log the new index.Generated with ❤️ by ellipsis.dev