Adjust onSettle index of Bottomsheet (49) #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| @@ -109,7 +109,7 @@ const BottomSheet = React.forwardRef<BottomSheetComponent, BottomSheetProps>( | |||
| borderWidth, | |||
| borderColor: borderColor ?? theme.colors.border.brand, | |||
| }} | |||
| onChange={(index) => onSettle?.(mappedSnapPoints.length - index - 1)} | |||
| onChange={(index) => onSettle?.(index)} | |||
There was a problem hiding this comment.
The initialSnapIndex logic still uses the reversed index logic (mappedSnapPoints.length - initialSnapIndex - 1). This might lead to inconsistencies with the onSettle callback behavior. Consider aligning this logic with the new onChange behavior.
sieu-db
changed the title
|
Published version: @draftbit/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updated
BottomSheetto use direct index foronSettlecallback, removing index reversal logic.Key points:
onChangeinpackages/core/src/components/BottomSheet/BottomSheet.tsxto use the direct index foronSettlecallback.onChangefunction.onSettlelogging inexample/src/BottomSheetExample.tsxto demonstrate new behavior.Generated with ❤️ by ellipsis.dev