Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expo 38 SDK #38

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Expo 38 SDK #38

wants to merge 13 commits into from

Conversation

baransu
Copy link

@baransu baransu commented Sep 23, 2020

No description provided.

davesnx
davesnx approved these changes Sep 23, 2020
View reviewed changes
Copy link

@davesnx davesnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @baransu, Thanks for the effort. Aside from the update of Expo SDK I see a few improvements that make me happy.

I left a few comments but mostly questions.

packages/reason-expo/src/Constants.re Outdated Show resolved Hide resolved
packages/reason-expo/src/Camera.re Show resolved Hide resolved
packages/reason-expo/src/BlurView.re Show resolved Hide resolved
packages/reason-expo/src/TaskManager.re Show resolved Hide resolved
packages/reason-expo/src/Location.re Show resolved Hide resolved
@baransu baransu marked this pull request as ready for review September 23, 2020 14:29
@MarcelCutts
Copy link

Still excitedly awaiting the season finale of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davesnx davesnx Awaiting requested review from davesnx

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baransu @MarcelCutts @davesnx