fix: AllocationTracker::Remove return value was reversed (#3341)

dragonflydb · Jul 19, 2024 · 4e8c6ce · 4e8c6ce
1 parent be59b5e
commit 4e8c6ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/core/allocation_tracker.cc b/src/core/allocation_tracker.cc
@@ -37,7 +37,7 @@ bool AllocationTracker::Remove(size_t lower_bound, size_t upper_bound) {
                                  }),
                   tracking_.end());
 
-  return before_size == tracking_.size();
+  return before_size != tracking_.size();
 }
 
 void AllocationTracker::Clear() {

diff --git a/src/core/allocation_tracker.h b/src/core/allocation_tracker.h
@@ -33,6 +33,8 @@ class AllocationTracker {
   bool Add(const TrackingInfo& info);
 
   // Removes all tracking exactly matching lower_bound and upper_bound.
+  // Returns true if the tracking range [lower_bound, upper_bound] was removed
+  // and false, otherwise.
   bool Remove(size_t lower_bound, size_t upper_bound);
 
   // Clears *all* tracking.