Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove redundant tests #3642

Merged
merged 5 commits into from
Sep 4, 2024
Merged

test: remove redundant tests #3642

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
858b637
test: remove redundant tests
cunla Sep 3, 2024
c84e97b
remove more tests
cunla Sep 3, 2024
ab43651
add test_bitmap_commands
cunla Sep 3, 2024
0fe1c6c
add test_bitmap_commands and test_geo_commands to ignore list
cunla Sep 4, 2024
4a22453
Merge branch 'main' into remove-redundant
cunla Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/test-fakeredis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ jobs:
- name: Run tests
working-directory: tests/fakeredis
run: |
poetry run pytest test/ --ignore test/test_hypothesis.py --ignore test/test_json/ \
poetry run pytest test/ \
--ignore test/test_hypothesis.py \
--ignore test/test_json/ \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you please add ignore test_bitmap_commands.py and
test_geo_commands.py (will save me a PR) ?
these are not very urgent to fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_geo_commands.py was not in the ignore list - is there another point where it is marked to be ignored?

Added test_bitmap_commands.py

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to add them here as --ignore ... because they are failing on Dragonfly. I think you removed test_bitmap_commands instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)
I thought you meant add them to run, not add them to the ignore list.

--ignore test_bitmap_commands.py \
--junit-xml=results-tests.xml --html=report-tests.html -v
continue-on-error: true # For now to mark the flow as successful
Expand Down
147 changes: 0 additions & 147 deletions tests/fakeredis/test/test_extract_args.py
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions tests/fakeredis/test/test_general.py
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions tests/fakeredis/test/test_mock.py
View file
Open in desktop

This file was deleted.

Loading