Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix flaky test test_acl_revoke_pub_sub_while_subscribed #3768

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: Fix flaky test test_acl_revoke_pub_sub_while_subscribed #3768

merged 1 commit into from
Sep 24, 2024

Commits on Sep 24, 2024

  1. fix: Fix flaky test test_acl_revoke_pub_sub_while_subscribed 

    The reason it failed is that, in some rare cases, the subscriber did not
get the first few messages of the publisher. This is likely due to
timing of subscribe and publish, in different connections / threads.

Given Pub/Sub has very weak guarantees, it's probably ok as is, so I
just added a sleep to get the test to pass always.
    @chakaz
    chakaz committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    465c375 View commit details
    Browse the repository at this point in the history