fix: make sure dfly_bench reliably connects #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
romange
commented
Sep 26, 2024
romange
commented
- Issue ping upon connect, add a comment why.
- log error if dfly_bench disconnects before all the requests were processed.
- Refactor memcache parsing code into ParseMC function.
romange
commented
Sep 26, 2024
| void Driver::ParseMC() { | ||
| unsigned blob_len = 0; | ||
|
|
||
| while (true) { |
There was a problem hiding this comment.
just moved the code here.
1. Issue ping upon connect, add a comment why. 2. log error if dfly_bench disconnects before all the requests were processed. 3. Refactor memcache parsing code into ParseMC function. Signed-off-by: Roman Gershman <[email protected]>
chakaz
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.