Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change Namespaces to be a global pointer #4032

Merged
merged 2 commits into from
Nov 10, 2024
Merged

chore: change Namespaces to be a global pointer #4032

merged 2 commits into from
Nov 10, 2024

Commits on Nov 10, 2024

  1. chore: change Namespaces to be a global pointer 

    Before the namespaces object was defined globally.
However it has non-trivial d'tor that is being called after main exits.
It's quite dangerous to have global non-POD objects being defined globally.
For example, if we used LOG(INFO) inside the Clear function , that would crash dragonfly on exit.

Ths PR changes it to be a global pointer.

Signed-off-by: Roman Gershman <[email protected]>
    @romange
    romange committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    9112a63 View commit details
    Browse the repository at this point in the history

  2. chore: comments

    @romange
    romange committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    7b3666c View commit details
    Browse the repository at this point in the history