Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select all peers in one scheduler_cluster #3503

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

alohaHZ
Copy link
Contributor

@alohaHZ alohaHZ commented Sep 11, 2024

old sql only select one item

Description

the old sql only select one item.
Then the peer deleted can not clean in time.The data displaayed in the console(Insight--peer) will be wrong

old sql only select one item
@alohaHZ alohaHZ requested a review from a team as a code owner September 11, 2024 12:58
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.97%. Comparing base (bba6b9b) to head (c37d3ce).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
manager/job/sync_peers.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3503      +/-   ##
==========================================
- Coverage   52.00%   51.97%   -0.03%     
==========================================
  Files         189      189              
  Lines       20270    20270              
==========================================
- Hits        10541    10536       -5     
- Misses       8928     8929       +1     
- Partials      801      805       +4     
Flag Coverage Δ
unittests 51.97% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/job/sync_peers.go 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alohaHZ Please fix lint.
image

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 820e719 into dragonflyoss:main Sep 24, 2024
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants