Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dfget): Change file path #3519

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

RoLuoGan
Copy link
Contributor

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.87%. Comparing base (526e5ef) to head (c6c6671).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
client/dfget/dfget.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3519      +/-   ##
==========================================
+ Coverage   51.78%   51.87%   +0.08%     
==========================================
  Files         190      190              
  Lines       20377    20377              
==========================================
+ Hits        10552    10570      +18     
+ Misses       9019     9004      -15     
+ Partials      806      803       -3     
Flag Coverage Δ
unittests 51.87% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/dfget/dfget.go 14.02% <0.00%> (ø)

... and 3 files with indirect coverage changes

@gaius-qi gaius-qi merged commit b226996 into dragonflyoss:main Sep 23, 2024
28 of 29 checks passed
@RoLuoGan RoLuoGan deleted the fix/dfget-typo-in-readme branch September 23, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants