quick fix for NIDEC #188
Open
quick fix for NIDEC #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NIDECs also have ACC_ON bit in ACC_HUD signal
|
Please submit any pr to our development repo at https://github.com/dragonpilot-community/dp-devel. We will happily considerate it there. |
sure,will do |
eFiniLan
reviewed
Apr 13, 2023
selfdrive/car/honda/carcontroller.py
Outdated
| @@ -74,6 +74,10 @@ def brake_pump_hysteresis(apply_brake, apply_brake_last, last_pump_ts, ts): | |||
| if ts - last_pump_ts < 0.2 and apply_brake > 0: | |||
| pump_on = True | |||
|
|
|||
| # some hybrid nidecs like Odyssey hybrid and Clarity need to keep pump on during braking or they'll lose pressure | |||
| if self.CP.carFingerprint == CAR.ODYSSEY_HYBRID: | |||
There was a problem hiding this comment.
this looks not necessary?
pump_on is always set to True for ODYSSEY_HYBRID AFTER the brake_pump_hysteresis?
|
@lijunhao731 我看到你在改新的 lp-dp-beta2 的代碼，你能夠幫我更新一下這個 PR 嗎？我看一下 ok 就後面整進去，謝啦! |
多谢Rick，这两天我整一下 |
已经更新啦，帮忙看一眼，谢啦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIDECs also have ACC_ON bit in ACC_HUD signal