Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't update the CRM DOM object in WP frontend #66

Open
wants to merge 1 commit into
base: 4.4-1.8
Choose a base branch
from

Conversation

agh1
Copy link
Contributor

@agh1 agh1 commented Oct 21, 2014

WordPress won't allow page content to update the header (https://issues.civicrm.org/jira/browse/CRM-13634) so the pub_key doesn't get saved under CRM.stripe.pub_key. This adds it via some inline javascript.

Without this, the x-1.8 versions of civicrm_stripe will not work for WordPress.

@drastik
Copy link
Owner

drastik commented Oct 30, 2014

I read in those threads this may not an issue since later 4.4.x versions, is it still an issue?

This effects Civi 4.4.something not 4.5 right?

Is this problem present on Event regi forms as well?

@agh1
Copy link
Contributor Author

agh1 commented Oct 30, 2014

Yeah, still an issue on 4.5 and won't be fixed in the near future. Some discussion of it at civicrm/civicrm-core#4440 relating to Coleman's fix for a related issue of addSetting in snippets failing

The exception to this problem is backend forms: I excluded the backend contribution form, but there should also be one for the backend event registration form.

@mattwire
Copy link
Contributor

@agh1 Is this still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants