Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conditional-formatting): support facade api #4300

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

Gggpound
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 13, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 46 seconds
commit  0d5d89a
info  For more information, see full report

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 363 lines in your changes missing coverage. Please review.

Project coverage is 33.56%. Comparing base (6bb96cc) to head (0d5d89a).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...tting/src/facade/conditional-formatting-builder.ts 0.00% 320 Missing ⚠️
...heets-conditional-formatting/src/facade/f-range.ts 0.00% 20 Missing ⚠️
...s-conditional-formatting/src/facade/f-worksheet.ts 0.00% 20 Missing ⚠️
...ts-conditional-formatting/src/facade/f-workbook.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4300      +/-   ##
==========================================
- Coverage   33.65%   33.56%   -0.10%     
==========================================
  Files        2499     2503       +4     
  Lines      128490   128853     +363     
  Branches    28783    28816      +33     
==========================================
  Hits        43246    43246              
- Misses      85244    85607     +363     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound force-pushed the feat-facade-cf-1213 branch from f717cf9 to 72db305 Compare December 13, 2024 13:42
@Gggpound Gggpound force-pushed the feat-facade-cf-1213 branch from 72db305 to 230a56a Compare December 13, 2024 13:43
@Gggpound Gggpound merged commit baa5201 into dev Dec 13, 2024
10 checks passed
@Gggpound Gggpound deleted the feat-facade-cf-1213 branch December 13, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants