Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes on scene startup #7

Open
wants to merge 2 commits into
base: release
Choose a base branch
from

Conversation

YakoYakoYokuYoku
Copy link

ReleaseNote

Compatibility (major, minor, patch, build): build
Jira ticket: N/A
Release Notes Comment: Fix crashes when simplyfing spaces with empty strings and using empty temporary dirs.

Special Notes:

Look or Scene Setup Change: No

Reviewers

N/A.

Pull request comments

Passing an empty string to replaceBlankToSingleSpace results in a failed assertion when calling result.back, so it'd be preferable to return early instead.

When a temporary dir is not set for getTmpDir Moonray is also going to crash with tmpDir.back, rather than that let's put a default value when is empty.

Rats test images

N/A.

Documentation (link)

N/A.

Unit Test Reminder

N/A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant