Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix Pinetab display issues #576

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Try to fix Pinetab display issues #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1f30a4
Try to fix Pinetab display issues
Aug 9, 2023
86afeb6
Add full fix-display patch info
aqtrans Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion PKGBUILDS/pine64/linux-megi/PKGBUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ buildarch=8
pkgbase=linux-megi
_desc="Megous Kernel"
pkgver=6.4.1
pkgrel=1
pkgrel=2
arch=('aarch64')
url="https://github.com/megous/linux"
license=('GPL2')
Expand Down Expand Up @@ -34,6 +34,7 @@ source=("linux-$_commit.tar.gz::https://github.com/megous/linux/archive/${_commi
'pinetab-accelerometer.patch'
'0002-dts-add-pinetab-dev-old-display-panel.patch'
'dts-pinetab-make-audio-routing-consistent-with-pinephone.patch'
'dts-pinetab-fix-display.patch'
# Bootsplash
'0002-revert-fbcon-remove-now-unusued-softback_lines-cursor-argument.patch'
'0003-revert-fbcon-remove-no-op-fbcon_set_origin.patch'
Expand Down Expand Up @@ -263,6 +264,7 @@ md5sums=('f2eaa521ceba559e3b61c18ed77a56ca'
'd0fd6bd627223d4c9fc001ffff9df401'
'3182f25beb0b76e8abd2e9de8213351d'
'60e9d1ccba52bd2634fbe8034b110e36'
'216feaeaf42d3adee3b23e2c96454e4c'
'a31a435ab6cd8e7a47601159d665ce50'
'fed6ae4ac4c3f56178fa4aca6c934d6f'
'ee3fad8e3468bba539a42ee3ed2b488f'
Expand Down
32 changes: 32 additions & 0 deletions PKGBUILDS/pine64/linux-megi/dts-pinetab-fix-display.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
From aa1c320dac3dd5a091953e2b7592d470fb71cda2 Mon Sep 17 00:00:00 2001
From: Dave Stevenson <[email protected]>
Date: Thu, 31 Mar 2022 12:03:36 +0100
Subject: [PATCH] drm/panel: ilitek-ili9881c: Clean up on mipi_dsi_attach
failure

mipi_dsi_attach is allowed to fail, and currently the probe
code doesn't clean up (mainly drm_panel_remove) if this happens.

Add cleanup code on failure.

Signed-off-by: Dave Stevenson <[email protected]>
---
drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index 6e03d9b0be60c..5446b07439f4a 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c 2023-07-01 20:46:40.000000000 +0000
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c 2023-08-08 23:47:37.069526508 +0000
@@ -919,7 +919,10 @@
dsi->format = MIPI_DSI_FMT_RGB888;
dsi->lanes = 4;

- return mipi_dsi_attach(dsi);
+ ret = mipi_dsi_attach(dsi);
+ if (ret)
+ drm_panel_remove(&ctx->panel);
+ return ret;
}

static void ili9881c_dsi_remove(struct mipi_dsi_device *dsi)