Add clock click action settings #992

xoascf · 2024-12-31T04:16:41Z

Clock Functionality Enhancements:

Removed the singleClick DispatcherTimer and its associated methods from Clock.xaml.cs, simplifying the clock's event handling (otherwise, delayed response for single clicking). [1] [2] [3]
Added support for various clock click actions (e.g., opening the Aero calendar, Modern calendar, Action Center for Windows 10/Notification Center for Windows 11) by updating the Clock_OnMouseLeftButtonDown method in Clock.xaml.cs.
Introduced a new ClockFlyoutLauncher class to handle the display of the Aero calendar flyout.

UI and Settings Adjustments:

Updated English.xaml to include new string resources for clock click actions and their values.
Modified PropertiesWindow.xaml to add a new combo box for selecting clock click actions in the settings UI.
Updated Settings.cs to include a new ClockClickOption enum and a corresponding property to store the user's clock click action preference. [1] [2]

Compatibility Improvements:

Added logic in PropertiesWindow.xaml.cs to list only available clock click actions for pre-Windows 10 systems, ensuring compatibility with previous versions of Windows (7, 8, 8.1). [1] [2]

Current Limitations:

If the user opens the Aero calendar while the taskbar is unlocked, the taskbar may inadvertently resize and/or change location.
If the user moves the mouse very quickly to open the Aero calendar, it might appear centered on the screen.
~~The Modern calendar is displayed for the primary screen only.~~ (f78d9b4: using ManagedShell implementation).
~~The Modern calendar might flicker when opened while trying to move to the corner.~~ ('').
~~The Modern calendar doesn't always open after clicking the clock (at least here for me on the latest Windows 10 LTSC).~~ ('').
Some Modern flyouts may still float above RetroBar if the stock taskbar is larger than it.

dremin

This is really nice! Mostly some questions below.

RetroBar/PropertiesWindow.xaml.cs

dremin · 2024-12-31T05:00:12Z

RetroBar/Utilities/ClockFlyoutLauncher.cs

+            // Keep the flyout at least 3 by 3 pixels inside the working area
+            int newX = (int)Math.Max(taskbarScreen.WorkingArea.Left + 3, Math.Min(taskbarScreen.WorkingArea.Right - (clockFlyoutRect.Width) - 3, clockFlyoutRect.Left));
+            int newY = (int)Math.Max(taskbarScreen.WorkingArea.Top + 3, Math.Min(taskbarScreen.WorkingArea.Bottom - (clockFlyoutRect.Height) - 3, clockFlyoutRect.Top));
+            SetWindowPos(clockFlyoutHwnd, IntPtr.Zero, newX, newY, 0, 0, (int)(NoPosFlags));


The last time I checked, it was the margin (spacing?) that separated the taskbar from the clock flyout in Windows 7, though I haven't checked if it applies to other screens with different scaling.

Hmm, I just compared and my Win7 has 2px additional on the X and 1px additional on the Y, at least with Aero.

After testing again, it appears that the correct value for both is 15 instead of 3.

Just to found out that Vista does not use spacing (no floating flyout)...

Maybe this should be customizable by the theme.

Given that RetroBar targets emulating Vista and below, let's remove the margin for now.

dremin · 2024-12-31T05:03:21Z

RetroBar/Utilities/ClockFlyoutLauncher.cs

+
+                className.Clear();
+                _ = GetClassName(hwnd, className, className.Capacity);
+                if (className.ToString() != "Windows.UI.Core.CoreWindow")


Is there any way we can more uniquely check this? There are a lot of modern windows with this class, and I was able to get this code to move them, for example by using the keyboard to activate another flyout at the same time.

Just found this Gist with C code that allows to "toggle the clock flyout in the Windows 10 taskbar on the monitor containing the mouse" (seems to be really complex, but it claims to be able to use other screens):
https://gist.github.com/valinet/bfc3e15d0d999cd3d2aab8d554955e6f

It seems that there's a program called "ExplorerPatcher", that allows to use the modern clock for the taskbar too: https://github.com/valinet/ExplorerPatcher

The Gist is also referenced here: valinet/ExplorerPatcher#67

Overwriting memory in explorer.exe seems not great but that does look like a way to fix the multi-screen support. However, we would still need this loop to move the window to the proper edge, and I think there are some issues with OS version support:

With the Windows 11 taskbar, there is no window representing the clock button, so I don't think the code would work.

On my Windows 10 VM, the clock button class is TrayClockWClass rather than ClockButton. I wonder where ClockButton came from? I see TrayClockWClass on Windows 7 as well.

Developers seem to use a different method to invoke the flyout (ImmersiveFlyouts.c#L59-L145), no idea if that helps, probably as undocumented as the other ways to invoke the other clock flyouts.

That method looks much better!

I have it working, but it is still non-functional in 24H2, due to the old taskbar code being removed from Windows. In light of this, I'm not sure we should pursue offering the modern calendar flyout option..

Good news, I have things working on 24H2 (well, even newer), and it also positions correctly using the API instead of needing to move the window. I'm working on a helper class for these flyouts in ManagedShell and once that is in we can use them.

The implementation works as it should, except with RetroBar (?), maybe some problem in the work area, I don't think we should move the flyout as before.

2 rows (works fine):

1 row (it's floating, but it shouldn't be):

The same issue can be replicated on Windows 10 when number of rows is 1:

Why is the clock there, near the Quick Launch?
I usually do this with the controls to make sure the flyout opens in the right place, whether it is at either end, or in the middle, or slightly to the left or right.

Seems to affect Start menu invoked flyouts too:

Yeah, that's a pre-existing issue with all of the flyouts. They won't overlap where the Explorer taskbar would be.

RetroBar/Utilities/ClockFlyoutLauncher.cs

RetroBar/Utilities/Settings.cs

RetroBar/Controls/Clock.xaml.cs

RetroBar/Languages/English.xaml

…onments

dremin · 2025-01-01T00:34:25Z

If the user opens the Aero calendar while the taskbar is unlocked, the taskbar may inadvertently resize and/or change location.
If the user moves the mouse very quickly to open the Aero calendar, it might appear centered on the screen.

I wasn't able to reproduce either of these, how are you able to make this happen?

The Modern calendar doesn't always open after clicking the clock (at least here for me on the latest Windows 10 LTSC).

How unreliable is it? With this and the other issues I am wondering if we should hide the option for this for now.

1280px · 2025-01-01T07:04:25Z

New strings for Russian l10n (left Modern untranslated because I think it refers to Windows 10's Modern UI?), also update 1 older string for consistency, starting line 54:

    <s:String x:Key="middle_mouse_task_action">Действие по _средней кнопке мыши:</s:String>
    <x:Array x:Key="middle_mouse_task_action_values" Type="s:String">
        <s:String>Ничего не делать</s:String>
        <s:String>Открыть новое окно задачи</s:String>
        <s:String>Закрыть задачу</s:String>
    </x:Array>
    <s:String x:Key="clock_click_action">Действие по нажатию на _часы:</s:String>
    <x:Array x:Key="clock_click_action_values" Type="s:String">
        <s:String>Ничего не делать</s:String>
        <s:String>Открыть Aero-календарь</s:String>
        <s:String>Открыть Modern-календарь</s:String>
        <s:String>Открыть центр уведомлений</s:String>
    </x:Array>

Also, the "Open Modern calendar" option doesn't work for me on Windows 11 24H2 :с

dremin · 2025-01-01T07:32:53Z

Also, the "Open Modern calendar" option doesn't work for me on Windows 11 24H2 :с

Ah, it doesn't work in my 24H2 VM either.

xoascf · 2025-01-01T09:16:03Z

Also, the "Open Modern calendar" option doesn't work for me on Windows 11 24H2 :с

Ah, it doesn't work in my 24H2 VM either.

Yeah, sorry, I haven't tested this on Windows 11 yet, so maybe that's why! 😅

dremin

Per the inline comment, in the interest of getting this PR merged, I think we should hide the option to open the Modern flyout for now given the various issues and lack of support in 24H2. We can add it back in a separate PR afterwards if the issues can be resolved.

Override settings without overwriting them, allowing the user to keep his or her settings while the behavior matches that of the system.

So we can use and call the system flyouts via API.

Let's use the API to invoke the system flyouts.

dremin

Thanks! 🎉

xoascf · 2025-01-09T06:05:20Z

New strings for Russian l10n (left Modern untranslated because I think it refers to Windows 10's Modern UI?), also update 1 older string for consistency, starting line 54:

    <s:String x:Key="middle_mouse_task_action">Действие по _средней кнопке мыши:</s:String>
    <x:Array x:Key="middle_mouse_task_action_values" Type="s:String">
        <s:String>Ничего не делать</s:String>
        <s:String>Открыть новое окно задачи</s:String>
        <s:String>Закрыть задачу</s:String>
    </x:Array>
    <s:String x:Key="clock_click_action">Действие по нажатию на _часы:</s:String>
    <x:Array x:Key="clock_click_action_values" Type="s:String">
        <s:String>Ничего не делать</s:String>
        <s:String>Открыть Aero-календарь</s:String>
        <s:String>Открыть Modern-календарь</s:String>
        <s:String>Открыть центр уведомлений</s:String>
    </x:Array>

Also, the "Open Modern calendar" option doesn't work for me on Windows 11 24H2 :с

@1280px, it would be nice to have those lines updated in a proper pull request.
By the way, you can check out the Modern calendar thing in the latest builds from GitHub Actions and see for yourself how it now works on Windows 11!

xoascf · 2025-01-09T07:22:11Z

If the user opens the Aero calendar while the taskbar is unlocked, the taskbar may inadvertently resize and/or change location.
If the user moves the mouse very quickly to open the Aero calendar, it might appear centered on the screen.

I wasn't able to reproduce either of these, how are you able to make this happen?

@dremin, just click on the clock to open the Aero calendar and move the cursor anywhere else (really quickly), the calendar may appear in the center, it may "lock" and allow the taskbar to drag it to any edge of the screen.

explorer_rb_drag_issue.mp4

dremin · 2025-01-09T07:29:34Z

If the user opens the Aero calendar while the taskbar is unlocked, the taskbar may inadvertently resize and/or change location.
If the user moves the mouse very quickly to open the Aero calendar, it might appear centered on the screen.

I wasn't able to reproduce either of these, how are you able to make this happen?

@dremin, just click on the clock to open the Aero calendar and move the cursor anywhere else (really quickly), the calendar may appear in the center, it may "lock" and allow the taskbar to drag it to any edge of the screen.
explorer_rb_drag_issue.mp4

Ah, I see. I think setting e.Handled=true in Clock_OnMouseLeftButtonDown might fix this, does that help?

Add clock click action settings

7185984

dremin self-requested a review December 31, 2024 04:17

dremin requested changes Dec 31, 2024

View reviewed changes

xoascf and others added 7 commits December 31, 2024 00:48

Change default ClockClickAction to DoNothing for pre-Windows 10 envir…

d72e613

…onments

Apply suggested changes

faca921

Change Aero calendar spacing to 15 pixels

cfa9848

Update Spanish translation

2d58be7

Update English (United Kingdom) translation

660be69

Remove LoadVersion() from PropertiesWindow constructor

065134e

Improve properties loading

2bc89bf

Normalize Aero clock flyout position and margin to Vista style

6bdc12f

dremin requested changes Jan 3, 2025

View reviewed changes

xoascf and others added 5 commits January 4, 2025 03:07

Merge remote-tracking branch 'upstream/master' into clock-flyout-options

d819f9f

Remove Modern calendar flyout option for Windows 11

58e27c3

Override settings without overwriting them, allowing the user to keep his or her settings while the behavior matches that of the system.

Update ManagedShell

4a4a99b

So we can use and call the system flyouts via API.

Reenable Modern calendar flyout option for Windows 11

f78d9b4

Let's use the API to invoke the system flyouts.

Minor ImmersiveShell fixes

d91764b

dremin approved these changes Jan 8, 2025

View reviewed changes

dremin merged commit 7539928 into dremin:master Jan 8, 2025
3 checks passed

xoascf deleted the clock-flyout-options branch January 8, 2025 02:05

xoascf linked an issue Jan 8, 2025 that may be closed by this pull request

Add an option for clock to open clock flyout instead of action centre on Windows 10 #858

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add clock click action settings #992

Add clock click action settings #992

xoascf commented Dec 31, 2024 •

edited

Loading

dremin left a comment

dremin Dec 31, 2024

xoascf Dec 31, 2024

dremin Dec 31, 2024

xoascf Dec 31, 2024

xoascf Dec 31, 2024

dremin Dec 31, 2024

dremin Dec 31, 2024

xoascf Dec 31, 2024

dremin Dec 31, 2024

xoascf Jan 1, 2025

dremin Jan 1, 2025

dremin Jan 1, 2025

dremin Jan 6, 2025 •

edited

Loading

xoascf Jan 7, 2025

xoascf Jan 7, 2025

dremin Jan 7, 2025

dremin commented Jan 1, 2025

1280px commented Jan 1, 2025

dremin commented Jan 1, 2025

xoascf commented Jan 1, 2025

dremin left a comment

dremin left a comment

xoascf commented Jan 9, 2025

xoascf commented Jan 9, 2025

dremin commented Jan 9, 2025

Add clock click action settings #992

Add clock click action settings #992

Conversation

xoascf commented Dec 31, 2024 • edited Loading

Clock Functionality Enhancements:

UI and Settings Adjustments:

Compatibility Improvements:

Current Limitations:

dremin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dremin Jan 6, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dremin commented Jan 1, 2025

1280px commented Jan 1, 2025

dremin commented Jan 1, 2025

xoascf commented Jan 1, 2025

dremin left a comment

Choose a reason for hiding this comment

dremin left a comment

Choose a reason for hiding this comment

xoascf commented Jan 9, 2025

xoascf commented Jan 9, 2025

dremin commented Jan 9, 2025

xoascf commented Dec 31, 2024 •

edited

Loading

dremin Jan 6, 2025 •

edited

Loading