Update NFDe implementation to v1.1.1 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the existing NFD implementation to [v1.1.1][1], including additional implementations for the DBus Portal API, which is useful for sandboxed applications to be able to choose files. As the interface into this library is the same as it was before, no existing appliction code needs to be updated. [1]: https://github.com/btzy/nativefiledialog-extended/releases/tag/v1.1.1
|
You can check the GH Action build for each platform. It's building fine. But I'm going to quickly test it to check if there is any problem on runtime. I'll get back to you. |
|
It looks like it's working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for distributing Gearsystem as a Flatpak application in #95, this pull request upgrades the source files for NFDe to the v1.1.1 release. Most notably, this also includes an implementation in
nfd_portal.cppthat supports the use of the Portal API used by Flatpak applications. This is necessary to have native file chooser dialogs that grant permission without needing machine-wide filesystem access.As I run this program on a Linux machine, I am unsure if the build works on the other platforms. Any verification that it continues to work as intended on those platforms would be greatly appreciated.