feature/multiplayer: prep drip-list-card: tabbed views #1007
Conversation
evvvritt
force-pushed
the
feature/multiplayer__ev/drip-list-cards
branch
from
aafbe45 to
43b8900
Compare
✅ Deploy Preview for drips-app-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Is it possible to make this animation go in the direction of the tab? like slide/fade left when you click "Current" and slide/fade right when you click "In Voting"?
|
|
I considered but think it looks kinda weird/nauseating? - maybe because the direction of the list is rightward so leftward animation seems more natural. Screen.Recording.2024-02-27.at.18.37.36.mov |
|
I like that better. @efstajas ? |
|
Just pushed this: Screen.Recording.2024-02-28.at.16.51.12.movWdyt? Also fyi @evvvritt i removed the |
|
Nice, transition looks good. |
|
it should be on its own line. see here why #950 |
|
All devices on it's own line? And if so, should it animate-in in some way? Same q for the mini-card we show in sections/Explore |
|
I don't understand your question sorry |
|
Should "Supported by..." be on it's own line on mobile and desktop view? If so, should it animate into view because that Supporter list is fetched on page load so the layout will shift once it's loaded. And then, worth noting that we currently use a different / "mini" drip-list-card component in drip-list-sections that appear in the Dashboard and Explore. Should that also have show "Supported by..." in it's own row. |
|
I think it makes more sense for the "supported by" line to be under the "current" tab. It would further reinforce the fact that the "in voting" list is off-chain and not supportable. |
|
But that seems like the supporters only apply to the current recipients. As if they'll be dropped once the voting round ends or something. Supporters apply to the whole Drip List, whether it's being voted on or not. Unless I'm misunderstanding you. If you're just talking about a draft drip list, there should be no "supported by" line in a draft drip list. |
* make list editor usable for mp contributors * date input component * splits component draft mode * allow custom righthand components in list editor * feature/multiplayer: prep drip-list-card: tabbed views (#1007) Co-authored-by: Georgios Jason Efstathiou <[email protected]> * Merge branch 'main' into feature/multiplayer * voting round creation flow, multiplayer module * fix * wip * wip * fix empty state condition of dl page * fix voting round schema * fix voting round schema even more * wip * wip * fix seeing other people's voting rounds * view votes * wip * wip * load existing vote data if any in vote flow * nicer transitions for voting round screen * voting rounds section draft * update status schema * load all voting round data client-side * wip * refresh drip list screen after submitting vote * touch up voting round review step * reactive voting round status * make voting round action buttons reactive * improve voting round splits transitions * tweak share button * assert drip list card props reactively * support card on voting round drafts * feat: drip-list-card-thumblink handles in-voting states (#1042) * feat: drip-list-card-thumblink handles in-voting states * copy change * move assert top-level * Feature/multiplayer ev/touchups (#1045) * style: no borders on annotation box * style: fix spacing, remove created-by tooltip * feat: add delete-voting-round button to annotation-box * fix voting-ended copy * feat: annotation-box supports custom icon, use in voting-round boxes * style: add drip graphic to voting round results in card * style: remove feather on splits table intro line, shorten gaps to drip graphic * style: nested splits line algins with parent drip| * fix: no drip if no voting results * trigger deploy * trigger deploy * prevent wrapping in state badge * trigger deploy * generate dynamic share images for voting rounds * allow voting for drip lists * update safe SDK * fix: drip list vote receivers don't appear in voting round splits * fix: Cannot use relative URL (/api/gql) with global fetch * refresh drip list page after publishing * private votes * fix * dynamic base URL for share buttons * make splits horizontally scrollable * currently connected collaborator is always on top of list * update receivers sorting * refactor list editor (#1055) * refactor list editor * fixes * fixes * visual fix * fix * update message tempaltes * more deets in viewVotingRound flow * fix success message on list publish with safe * fix editing drip list with drip list on it * add ability to pull in your previous vote for private voting rounds * fix "view vote" button appearing when not yet voted * fix previous vote not applied when updating vote in public voting round * update api object key name * fix list-editor valid condition * api schema update * change date input placeholder * fix e2e tests * actually fix e2e tests * fix svelte_check * temporalily ignore warnings in svelte-check action * fix * new link method for safes, jsdocs for multiplayer module * fixes * fix * fix unit tests env vars * update env.template * adjust copy on voting round review step * fix e2e tests --------- Co-authored-by: evvvritt <[email protected]>
drip-list-card.svelteinto a-thumblink.sveltefor sections, and a default/full version?tabsto drip list page url to view) – example